remove kube-rbac-proxy reference - #261
Merged
Merged
Conversation
mazin-s
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is to remove kube-rbac-proxy sidecar container from ndb-operator and utilieze controller runtime native authorization to secure metrics server.
Kube-rbac-proxy mainly helps to secure http communications to access controller metrics using token. Since the newer versions of operator-sdk and kube-builder have native support for the same kuberbac-proxy can be removed.
Advantages:
How Has This Been Tested?:
The testing is done based on kube-rbac-proxy capabilities. Comparison is done to check functionalities before and after removing kube-rbac-proxy.
Before removing kube-rbac-proxy
After removing kube-rbac-proxy
Special notes for your reviewer:
Release note:
use latest operator sdk version.
remove kube-rbac-proxy support.