Repository navigation
Add nbb and let-go to the compatibility matrix - #19
Merged
Merged
Conversation
Both are easy to install in CI: nbb from npm and let-go from its releases. Every server in the matrix is also something proof serve can act like, so this adds scenarios for what they do differently: - no-eval-error: an error comes with err and ex, but without the eval-error status (nbb and let-go). - ansi-errors: error messages are colored with ANSI escape codes (let-go). - read-line-waits: there's no stdin op, and reading input waits until the eval is interrupted or its session closed (let-go reads the terminal it runs in, where its own REPL takes the lines). - no-version-string: versions.nrepl has the numbers of the version as strings, but no version-string (let-go). let-go has no *1, so its session-state snippet switches namespaces, which let-go shares between sessions. Its interrupt can't stop an eval (it says session-idle from another connection, and waits for the eval on the same one), and describe doesn't list it, so the interrupt checks skip. Conflicting scenarios are groups now, as there are three ways to read input without a stdin op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both come with scenarios for
proof serve -like, as every server in the matrix does. nbb stops taking connections after a frame that isn't a dict, which is the most serious thing the matrix found here.