Repository navigation
Publish the compatibility matrix on GitHub Pages - #18
Merged
Merged
Conversation
describe's versions can't be trusted for this: nbb says TODO, let-go says 1.0 while it's 1.13.0, and jank says jank-0.1-alpha whatever the build. So a profile can have a version snippet now, which proof evaluates in a session of its own before the checks. The text and JSON reports and the Markdown matrix show what it evaluates to after the name of the server. The bundled profiles that install the latest release (or main) get one. nREPL and ClojureCLR keep the version they pin in their names, and jank has no way to tell its version from the code.
So far the matrix lived in the summary of the Compatibility workflow, which few people would find. Now proof matrix -html builds it as a web page, where hovering over a check shows why it matters and hovering over a verdict shows what went wrong, and the workflow publishes it from main. The page gets published only when every server's job succeeded, as a page that's a day old beats one that's missing a server. The runs build proof with the latest Go and the whole history, so the reports (and the page) say which commit of proof made them. The table is written without html/template, which would make the binary 2 MB bigger. A check that only a later report has now goes with the rest of its group, in the Markdown matrix as well.
The matrix gets a page of its own, along with nbb, let-go and two more clients. The upstream section catches up with what got merged and reported since 0.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix gets a page of its own at https://nrepl.github.io/proof/, with the version of each server. The versions come from a new
versionsnippet rather than describe, which gets them wrong for nbb, let-go and jank.