Repository navigation
Report killed evals as errors and show UTF-8 as text - #5
Merged
Merged
Conversation
A worker that died with reason killed was always answered with interrupted, so an eval that ran exit(self(), kill), or got killed by something else on the node, looked as if the client had interrupted it. The session now remembers that it killed the worker for an interrupt, and any other kill is an eval-error.
Values go through ~tp, which prints <<"здравей"/utf8>> as a list of bytes unless the node runs with +pc unicode. bin/dialtone owns its node, so it turns that on. An embedded server keeps the node's setting.
A worker that died of something else just before an interrupt reached it, with its DOWN still on its way, was answered with interrupted, so its error got lost.
When a later form in an eval failed, the session went back to its state from before the eval, so `X = 1. error(boom).` left X unbound, although the client had already seen its value. In the shell each form is a line of its own, and X would stay. Now the forms that ran keep their bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An eval whose worker got killed by anything other than an interrupt (e.g.
exit(self(), kill)) came back asinterrupted, as if the client had stopped it. Andbin/dialtoneshowed<<"здравей"/utf8>>as a list of bytes, since~tpprints UTF-8 as text only with+pc unicode. An embedded server keeps whatever its node uses.The forms before one that fails keep their bindings now, as they would in the shell, where each form is a line of its own.