Repository navigation
Leave the reload repairs to cider-nrepl 0.64.1 - #87
Merged
Merged
Conversation
cider-nrepl 0.64.1 points the aliases and refers on the namespaces its reloads make anew at the new ones, for every client, and puts the session that asked for the reload back in its namespace. Jack-in brings it now, so neorepl's own relinking goes, and its re-entry only runs for a cider-nrepl before 0.64.1, going by describe's cider-version, until that's the oldest one supported. ,reload sends refresh in the REPL's session, so cider-nrepl puts that one back, and sends it again without the session in a ClojureScript one, where refresh answers clojure-only. The REPL's own follow-up, which evaluated in-ns and left *1 holding the namespace, goes too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cider-nrepl 0.64.1 does after its reloads what neorepl did by hand. The session re-entry stays for an older cider-nrepl, behind describe's
cider-version, since servers that CIDER jacks in or a project pins won't have 0.64.1 for a while. The alias relinking never shipped in a release, so it just goes.