Repository navigation
Show spec examples from cider-nrepl - #81
Merged
Merged
Conversation
cider-nrepl's spec-example op answers with the example under :spec-example, while neorepl looked for :example, which is what the fake in the tests sent. So against a real cider-nrepl, x in the spec browser said there was no such spec, for every spec. The fake now answers as cider-nrepl 0.64.0 does, and the Leiningen project in the integration tests gets test.check, so the example from a real cider-nrepl is tested too, while the deps.edn one still checks what happens without it.
bbatsov
force-pushed
the
fix-spec-example
branch
from
November 5, 2026 14:44
80f10ae to
2af64d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With cider-nrepl,
xin the spec browser said there was no such spec, whatever the spec. cider-nrepl'sspec-exampleanswers under:spec-example, and the fake the tests used answered under:example, so nothing caught it. The Leiningen project in the integration tests now has test.check, so the example from a real cider-nrepl gets checked as well.