Repository navigation
Conversation
jeffkl
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a workspaces project,
npm ls --workspaces=falsecrashes withCannot read properties of null (reading 'isWorkspace')whenever the root has a dependency that isn't installed, whether it's missing, omitted, or skipped as a platform-specific optional dep. The--workspaces=falsecheck infilterBySelectedWorkspacesreadedge.to.isWorkspacewithout checking for a nulledge.to, which is what a missing dependency's edge has. The other checks in that function already guard for it, so this adds the same guard. The output now matches plainnpm lswithout the workspaces.Testing
Added a
--workspaces=falseversion of the existing "workspace and missing optional dep" test. It crashes before the change and passes after. The full suite passes locally.References
Fixes #10157