P1: expose process lifecycle via process_status and output-loss fields - #61
Merged
Merged
Conversation
exec_command stays spawn identity; agents need a handle API to judge exit and truncated logs without treating EOF as success. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_idis now a lifecycle handle:process_statusreportsrunning|exitedplus termination metadata (exited/timeout/terminated/unknown).read_processaddsoutput_lostandretained_fromso a truncated 256 KiB window is not silent. EOF is not success.exec_commandspawn identity is unchanged (notty_size). UDSWIRE_PROTOCOLis 4 so older workers fail fast.Test plan
cargo test --locked --offline(root workspace)cargo clippy -p codespace-domain -p codespace-runner -p codespace-server --all-targets --offline -- -D warningscargo test --locked --offline --manifest-path crates/codex-runtime/Cargo.toml --test runtime_binarypython3 -B scripts/check_docs.py checkOut of scope
exec_command.tty_size, MCPprocess_resize/process_wait, signals, OS PIDprocess_idMade with Cursor