Pin docs-actions deploy to the reviewed Node 24 Pages action - #45
Merged
Merged
Conversation
The reusable workflow now calls deploy-pages v5.0.1. That removes the Node 20 runner warning without changing the caller-owned Pages contract. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #
Summary
CodeSpace adopts the reviewed docs-actions merge that moves Pages deploy from
actions/deploy-pagesv4 (Node 20) to v5.0.1 (Node 24). The caller still builds and verifies; only the pinned reusable deploys.pages: writeandid-token: writestay on the deploy job.secrets: inheritis not used.Pin:
e110843b00303c1418cf8950ba8c5789acc31cbe(merge of novelKR/docs-actions#2). Workflowsha25674419dfb5d506177e3d04a97175148b6652032188ada02d0245873504d235f9e.Contract changes
None. No MCP tool schemas, error codes, or status values change.
Tests
Reviewed docs-actions#2: reusable workflow and
contracts/pages-deploy-v1.jsonchange only the deploy-pages SHA. Centralcontractsanddocs-buildchecks passed. This PR only updates.github/workflows/docs.ymluses:and.github/docs-pages-deploy.lock.json.Live site after enabling Pages (GitHub Actions source) and rerunning the failed deploy:
https://novelkr.github.io/CodeSpace/returned HTTP 200.Security scenarios
main. Thegithub-pagesenvironment already allows onlymain.Out of scope
docs-site/PROVENANCE.jsonstays on the original copy commit)Made with Cursor