Repository navigation
feat: offer shared alert starters for newly connected services - #77
Conversation
WalkthroughDocs-only: the Assessment
Verdict: APPROVE — docs-only change; the review feedback is implemented and verified against the companion docs; CI green; no correctness, security or performance concerns. |
brycebaril
left a comment
There was a problem hiding this comment.
The workflow is right, and the names match the server:
list_alert_starterstakes no arguments, and itsspecgoes toset_alert_rulewithtenant. The skill says not to pass the id, title or why, whichset_alert_rulewould refuse as unknown keys.- It checks existing names and coverage first, and saves only once the user says so. It leaves
enabledalone, so an existing rule someone switched off stays off. - CI is green.
Before merge: the other copy of ns-manage-alerts, the one the VS Code extension installs its Console 7 skills from, needs this section too. The two copies have diverged:
- That copy documents rules on several metrics (
metric.values, letters A to E). This one doesn't. - Two of the 14 starters,
clock-skewandbusy-and-saturated, usevalues. - A change made only here misses the extension now, and has to be carried over by hand when the skills are published here at launch.
| - Preview what it would have caught using step 3 below, and show the final | ||
| spec. Once the user authorizes saving, pass that spec with the selected | ||
| `tenant` to `set_alert_rule`; do not pass the starter's id, title or why. | ||
| Keep each metric's letters, windows, conditions and hold times unless the |
There was a problem hiding this comment.
In this copy of the skill, nothing explains letters or metric.values. The other copy does, in step 1's "Several metrics". So this line, and the two starters that use letters, read better there.
A newly connected service can now start from the Console 7 alert catalog instead of copied rule definitions.
ns-manage-alertscallslist_alert_starters, checks existing rule names and coverage, and offers useful missing starters before saving throughset_alert_rule.The workflow reviews service scope, existing notification channels, thresholds and diagnostics with the user. It keeps explicit approval before writes and handles an older server without the catalog tool.
Validation
node scripts/sync-plugin-assets.mjs --checknode scripts/materialize-github-marketplace.mjs --checkCompanion changes