Repository navigation
feat: accept alpha versions in YAML comments - #729
Conversation
Node.js 27 introduces Alpha releases versioned as vN.0.0-alpha.X.Y.Z (see nodejs/node#63135), and REPLACEME placeholders are replaced with the full Alpha version when releasing them. Accept those versions in the YAML comments of the docs. Refs: nodejs/Release#1187 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
|
Change looks good to me. I'm sure releasers have thought about this, but just in case: I'm not sure if these eventually get replaced with production release numbers or not, but I hope so. Seems like we should only include production releases in the docs, since something might be introduced in 20.0.0-alpha1 but not actually show up in a production release until 20.17.2 or whatever. And it's that second number that matters for someone trying to figure out what versions of Node.js they support. |
|
@nschonni You and I are the only people who have merged anything in this repository in the last 6 months. Any chance you want to review this? (If not, no problem, I'll just go ahead and merge it.) |
| Array.from({ length: 3 }, () => Number.MAX_SAFE_INTEGER).join("."), | ||
| ); | ||
| const validVersionNumberRegex = /^v\d+\.\d+\.\d+$/; | ||
| const validVersionNumberRegex = /^v\d+\.\d+\.\d+(?:-alpha\.\d+\.\d+\.\d+)?$/; |
There was a problem hiding this comment.
Took a look at https://www.npmjs.com/package/semver, and it does seem like the call on 62 could be replaced with a call to semverValid
There was a problem hiding this comment.
But that would be more permissive, wouldn't it? It would permit valid semver versions that we don't use in the project, I think?
There was a problem hiding this comment.
Yeah, I think that's why it wasn't used in the original PR
|
The GitHub Action successfully published the package, but then failed..... https://github.com/nodejs/remark-preset-lint-node/actions/runs/39009971958/job/117330590785 Guess we should debug that...... |
|
3 participants
feat: accept alpha versions in YAML comments