Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/internal/streams/operators.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const {
ArrayPrototypePush,
Boolean,
MathFloor,
MathTrunc,
Number,
NumberIsNaN,
Promise,
Expand Down Expand Up @@ -314,10 +315,11 @@ function toIntegerOrInfinity(number) {
if (NumberIsNaN(number)) {
return 0;
}
if (number < 0) {
const integer = MathTrunc(number);
if (integer < 0) {
throw new ERR_OUT_OF_RANGE('number', '>= 0', number);
}
return number;
return integer;
}

function drop(number, options = undefined) {
Expand Down
13 changes: 13 additions & 0 deletions test/parallel/test-stream-drop-take.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ const naturals = () => from(async function*() {
})().then(common.mustCall());
}

{
// Fractional limits are truncated toward zero
(async () => {
assert.deepStrictEqual(await from([1, 2, 3, 4]).take(1.5).toArray(), [1]);
assert.deepStrictEqual(await from([1, 2, 3, 4]).drop(1.5).toArray(), [2, 3, 4]);
assert.deepStrictEqual(await from([1, 2, 3, 4]).take(0.5).toArray(), []);
assert.deepStrictEqual(await from([1, 2, 3, 4]).drop(0.5).toArray(), [1, 2, 3, 4]);
assert.deepStrictEqual(await from([1, 2]).take(-0.5).toArray(), []);
assert.deepStrictEqual(await from([1, 2]).drop(-0.5).toArray(), [1, 2]);
})().then(common.mustCall());
}

{
// Support for AbortSignal
const ac = new AbortController();
Expand Down Expand Up @@ -108,6 +120,7 @@ const naturals = () => from(async function*() {
// Error cases
const invalidArgs = [
-1,
-1.5,
-Infinity,
-40,
];
Expand Down
Loading