Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
backup() only checked that the source argument was a BaseObject before casting it to Database, so passing a Statement or Session caused a type confusion. Check against the DatabaseSync constructor template instead. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
sqlite-backup-type-check
branch
from
October 16, 2026 18:33
3b9b0f3 to
66f69bb
Compare
cjihrig
approved these changes
Oct 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66797 +/- ##
==========================================
+ Coverage 90.47% 90.50% +0.02%
==========================================
Files 791 797 +6
Lines 277225 277804 +579
Branches 53313 53364 +51
==========================================
+ Hits 250829 251414 +585
+ Misses 16801 16792 -9
- Partials 9595 9598 +3
🚀 New features to boost your workflow:
|
Cache the template so a shared IsolateData can load the binding twice. Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
araujogui
force-pushed
the
sqlite-backup-type-check
branch
from
October 18, 2026 15:36
e488536 to
9402d56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backup()cast anyBaseObjecttoDatabase*, so passing aStatementSyncorSessioncaused a type confusion. It now checksHasInstance()against theDatabaseSynctemplate.