Skip to content

build: load gtest_main using pkg-config - #66675

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:gtest-test-only
Oct 19, 2026
Merged

build: load gtest_main using pkg-config#66675
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:gtest-test-only

Conversation

@aduh95

@aduh95 aduh95 commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

…instead of hardcoding its libname in GYP

Follow up of #66626, marking it as dont-land in case it breaks someone

To confirm this, I ran the following command before:

$ ninja -C out/Release -t commands -s cctest | sed 's/ /\n/g' | grep gtest
-lgtest_main
-L/nix/store/ifc0v07gkb2bxhsidd8kgrp69bqkqmnd-gtest-1.18.0/lib
-lgtest

And after:

$ ninja -C out/Release -t commands -s cctest | sed 's/ /\n/g' | grep gtest 
-L/nix/store/ifc0v07gkb2bxhsidd8kgrp69bqkqmnd-gtest-1.18.0/lib
-lgtest_main
-lgtest

@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 12, 2026
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels Oct 12, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78340/

@aduh95
build: load gtest_main using pkg-config
d4799b9 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78407/

@legendecas legendecas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 16, 2026
legendecas
legendecas reviewed Oct 16, 2026
View reviewed changes
Comment thread configure.py Outdated
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2026
@aduh95 aduh95 added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 16, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78445/

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Oct 16, 2026
@nodejs-github-bot
nodejs-github-bot merged commit cd192cd into nodejs:main Oct 19, 2026
76 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Landed in cd192cd

@nodejs-github-bot nodejs-github-bot removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes
@UlisesGascon UlisesGascon Awaiting requested review from UlisesGascon
@richardlau richardlau Awaiting requested review from richardlau

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @legendecas