Skip to content

vfs: return FileHandle from fs.promises.open - #65730

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-promises-open-internals
Open

vfs: return FileHandle from fs.promises.open#65730
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:vfs-promises-open-internals

Conversation

@trivikr

@trivikr trivikr commented Sep 2, 2026

Copy link
Copy Markdown
Member

Fixes: #65729

Wrap mounted virtual file descriptors in the public FileHandle interface while delegating operations to the underlying provider handle.


Assisted-by: codex:gpt-5.6-sol

Wrap mounted virtual file descriptors in the public FileHandle
interface while delegating operations to the underlying provider
handle.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vfs Issues and PRs related to the virtual filesystem subsystem. labels Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (f9ab994) to head (576a7a4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/vfs/fd.js 87.17% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65730      +/-   ##
==========================================
- Coverage   90.07%   90.04%   -0.03%     
==========================================
  Files         754      754              
  Lines      256395   256433      +38     
  Branches    48494    48499       +5     
==========================================
- Hits       230947   230914      -33     
- Misses      16563    16624      +61     
- Partials     8885     8895      +10     
Files with missing lines Coverage Δ
lib/internal/vfs/setup.js 87.32% <100.00%> (-0.02%) ⬇️
lib/internal/vfs/fd.js 96.03% <87.17%> (-1.67%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfs: mounted fs.promises.open returns internal VFS handle instead of FileHandle

2 participants