doc: clarify FileHandle error handling#63719
Open
bobu-putheeckal wants to merge 1 commit into
Open
Conversation
Fixes: nodejs#51135 Signed-off-by: Bob Put <bobu.work@gmail.com>
0d795e7 to
67eb595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51135
This clarifies that
filehandle.close()andfilehandle.stat()promises may reject when the underlying file system operation fails, and points readers to Common System Errors forcodevalues.Evidence checked:
FileHandle.prototype.stat()callsfsCall(fstat, this, options)inlib/internal/fs/promises.js.fstat()usesbinding.fstat(..., kUsePromises)and routes binding failures throughhandleErrorFromBinding.FileHandle::ClosePromise()insrc/node_file.ccdocuments that the close promise rejects with a UVException if closing the fd fails.filehandle.stat()rejecting withEBADFafter the handle is closed.Validation:
git diff --checknode tools/lint-md/lint-md.mjs doc/api/fs.mdnpx -q core-validate-commit --no-validate-metadata --tap HEAD