doc: clarify fs.copyFile() error handling#63544
Open
bobu-putheeckal wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
doc
Fixes: nodejs#52916 Signed-off-by: Bob Put <bobu.work@gmail.com>
bobu-putheeckal
force-pushed
the
codex-doc-52916
branch
from
beb052b to
b5a2230
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52916
This clarifies how
fsPromises.copyFile(),fs.copyFile(), andfs.copyFileSync()surface errors and points readers to Common System Errors forcodevalues.Evidence checked:
fsPromises.copyFile()callsbinding.copyFile(..., kUsePromises)inlib/internal/fs/promises.js.fs.copyFile()andfs.copyFileSync()both route throughbinding.copyFile()inlib/fs.js.uv_fs_copyfileinsrc/node_file.cc, so failures surface as the usual file-system errors for the promise, callback, and sync APIs respectively.Validation:
git diff --checknode tools/lint-md/lint-md.mjs doc/api/fs.mdnpx -q core-validate-commit --no-validate-metadata --tap HEAD