Skip to content

Commit 10b3d25

Browse files
committed
quic: update http3 to use update recv_settings2 callback
1 parent 185bcfa commit 10b3d25

1 file changed

Lines changed: 22 additions & 23 deletions

File tree

src/quic/http3.cc

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -763,13 +763,11 @@ class Http3ApplicationImpl final : public Session::Application {
763763
session().Close(Session::CloseMethod::GRACEFUL);
764764
}
765765

766-
void OnReceiveSettings(const nghttp3_settings* settings) {
766+
void OnReceiveSettings(const nghttp3_proto_settings* settings) {
767767
options_.enable_connect_protocol = settings->enable_connect_protocol;
768768
options_.enable_datagrams = settings->h3_datagram;
769769
options_.max_field_section_size = settings->max_field_section_size;
770770
options_.qpack_blocked_streams = settings->qpack_blocked_streams;
771-
options_.qpack_encoder_max_dtable_capacity =
772-
settings->qpack_encoder_max_dtable_capacity;
773771
options_.qpack_max_dtable_capacity = settings->qpack_max_dtable_capacity;
774772
Debug(&session(),
775773
"HTTP/3 application received updated settings: %s",
@@ -1053,7 +1051,7 @@ class Http3ApplicationImpl final : public Session::Application {
10531051
}
10541052

10551053
static int on_receive_settings(nghttp3_conn* conn,
1056-
const nghttp3_settings* settings,
1054+
const nghttp3_proto_settings* settings,
10571055
void* conn_user_data) {
10581056
NGHTTP3_CALLBACK_SCOPE(app);
10591057
app.OnReceiveSettings(settings);
@@ -1079,25 +1077,26 @@ class Http3ApplicationImpl final : public Session::Application {
10791077
CHECK(ncrypto::CSPRNG(dest, destlen));
10801078
}
10811079

1082-
static constexpr nghttp3_callbacks kCallbacks = {on_acked_stream_data,
1083-
on_stream_close,
1084-
on_receive_data,
1085-
on_deferred_consume,
1086-
on_begin_headers,
1087-
on_receive_header,
1088-
on_end_headers,
1089-
on_begin_trailers,
1090-
on_receive_trailer,
1091-
on_end_trailers,
1092-
on_stop_sending,
1093-
on_end_stream,
1094-
on_reset_stream,
1095-
on_shutdown,
1096-
on_receive_settings,
1097-
on_receive_origin,
1098-
on_end_origin,
1099-
on_rand,
1100-
nullptr};
1080+
static constexpr nghttp3_callbacks kCallbacks = {
1081+
on_acked_stream_data,
1082+
on_stream_close,
1083+
on_receive_data,
1084+
on_deferred_consume,
1085+
on_begin_headers,
1086+
on_receive_header,
1087+
on_end_headers,
1088+
on_begin_trailers,
1089+
on_receive_trailer,
1090+
on_end_trailers,
1091+
on_stop_sending,
1092+
on_end_stream,
1093+
on_reset_stream,
1094+
on_shutdown,
1095+
nullptr, // recv_settings (deprecated)
1096+
on_receive_origin,
1097+
on_end_origin,
1098+
on_rand,
1099+
on_receive_settings};
11011100
};
11021101

11031102
std::unique_ptr<Session::Application> CreateHttp3Application(

0 commit comments

Comments
 (0)