Skip to content

Commit 185bcfa

Browse files
committed
quic: temporarily disable ngtcp2 test binaries
1 parent 0cf4725 commit 185bcfa

3 files changed

Lines changed: 18 additions & 2 deletions

File tree

deps/ngtcp2/ngtcp2.gyp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,10 @@
247247
},
248248
{
249249
'target_name': 'ngtcp2_test_server',
250-
'type': 'executable',
250+
# Disabled: ngtcp2 examples now require C++23 (<print>, <expected>,
251+
# std::println, std::expected) which is not yet supported on all
252+
# Node.js platforms. Re-enable when C++23 is available.
253+
'type': 'none',
251254
'cflags': [ '-Wno-everything' ],
252255
'include_dirs': [
253256
'',
@@ -305,7 +308,10 @@
305308
},
306309
{
307310
'target_name': 'ngtcp2_test_client',
308-
'type': 'executable',
311+
# Disabled: ngtcp2 examples now require C++23 (<print>, <expected>,
312+
# std::println, std::expected) which is not yet supported on all
313+
# Node.js platforms. Re-enable when C++23 is available.
314+
'type': 'none',
309315
'cflags': [ '-Wno-everything' ],
310316
'include_dirs': [
311317
'',

test/parallel/test-quic-test-client.mjs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// Flags: --experimental-quic
22
import { hasQuic, isAIX, isIBMi, isWindows, skip } from '../common/index.mjs';
33
import assert from 'node:assert';
4+
import { existsSync } from 'node:fs';
5+
import { resolve } from 'node:path';
46

57
if (!hasQuic) {
68
skip('QUIC support is not enabled');
@@ -20,6 +22,9 @@ if (isWindows) {
2022
// required by the ngtcp2 example server/client.
2123
skip('QUIC third-party tests are disabled on Windows');
2224
}
25+
if (!existsSync(resolve(process.execPath, '../ngtcp2_test_client'))) {
26+
skip('ngtcp2_test_client binary not built');
27+
}
2328

2429
const { default: QuicTestClient } = await import('../common/quic/test-client.mjs');
2530

test/parallel/test-quic-test-server.mjs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// Flags: --experimental-quic
22
import { hasQuic, isAIX, isIBMi, isWindows, skip } from '../common/index.mjs';
3+
import { existsSync } from 'node:fs';
4+
import { resolve } from 'node:path';
35

46
if (!hasQuic) {
57
skip('QUIC support is not enabled');
@@ -19,6 +21,9 @@ if (isWindows) {
1921
// required by the ngtcp2 example server/client.
2022
skip('QUIC third-party tests are disabled on Windows');
2123
}
24+
if (!existsSync(resolve(process.execPath, '../ngtcp2_test_server'))) {
25+
skip('ngtcp2_test_server binary not built');
26+
}
2227

2328
const { default: QuicTestServer } = await import('../common/quic/test-server.mjs');
2429
const fixtures = await import('../common/fixtures.mjs');

0 commit comments

Comments
 (0)