chore: more customizing#817
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
README documents both options; unit and integration tests cover Reviewed by Cursor Bugbot for commit 55c78ba. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 55c78ba. Configure here.
| const renderTag = (tag, attrs) => { | ||
| const rendered = Object.entries(attrs) | ||
| .filter(([, value]) => value != null && value !== false) | ||
| .map(([key, value]) => (value === true ? ` ${key}` : ` ${key}="${value}"`)) |
There was a problem hiding this comment.
Attribute values not HTML-escaped in renderTag
Medium Severity
renderTag interpolates attribute values directly into double-quoted HTML attributes without escaping special characters. A content value containing a double quote (e.g. a project description like The "best" toolkit) produces malformed HTML (content="The "best" toolkit"), breaking the tag and potentially causing the downstream HTML minifier to error or emit garbled output. Ampersands in URLs with query parameters (?a=1&b=2) are also technically invalid. Values need at least " → " and & → & encoding.
Reviewed by Cursor Bugbot for commit 55c78ba. Configure here.


Adds more customizability into the
webgenerator, with custom templating and lightningcss options