Skip to content

jenkins: skip SmartOS for pull request tests #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 1 commit into
base: main
Choose a base branch
from
Open

jenkins: skip SmartOS for pull request tests #4518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ def noVer = { nodeVersion -> false }
def releaseType = { buildType -> buildType == 'release' }
def testType = { buildType -> buildType == 'test' }
def anyType = { buildType -> true }
// node-test-pull-request passes the pull ref down to every sub-job; daily
// and release jobs pass a branch ref
def isPullRequest = new String(parameters['GIT_REMOTE_REF'] ?: '') ==~ /refs\/pull\/.+/
def prTestType = { buildType -> buildType == 'test' && isPullRequest }

def buildExclusions = [
// Given a machine label, build type (release or !release) and a Node.js
Expand Down Expand Up @@ -54,6 +58,9 @@ def buildExclusions = [
[ /^aix72-power9/, releaseType, lt(26) ], // Build releases on Power 9 for >=26

// SmartOS -----------------------------------------------
// Not run for pull requests, node-daily-* still covers them
// https://github.com/nodejs/build/issues/4457
[ /^smartos/, prTestType, allVer ],

@sxa sxa Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we still allow it to be run on codestreams other than main? My gut feel is that this would still be containable.

Suggested change
[ /^smartos/, prTestType, allVer ],
[ /^smartos/, prTestType, gte(27) ],

@panva panva Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion is not the same as "other than main" though is it?

@sxa sxa Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not explicitly - it was an (untested) approximation to achieve something equivalent today based on the current versions which should help alleviate concerns with the amount of time that node-test-pull-request can take.

[ /^smartos22/, anyType, gte(26) ],

// Shared libs docker containers -------------------------
Expand Down
Loading