Add RISC-V support to select-compiler.sh - #4451
Open
sxa wants to merge 1 commit into
Open
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
targos
approved these changes
Sep 1, 2026
richardlau
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've put this new section at the top with an architecture-specific clause for now so it would override any of the defaults for Debian/Ubuntu in the future however since I've now removed most of of the RISC-V magic bits into nodejs/node#65708 this could potentially be changed. We'll likely revisit when we're able to get some production machines into the CI anyway ... At the moment some of the systems have multiple versions of clang available so I'm locking this to 21 which is available on all of them (and not locking RUST as the version in each environment varies)
The systems I have for now are running
bianbuorarmbiandistributions so I could make the switch statement*armbian*|*bianbu*)but I'd prefer to keep it like this for now to give me some flexibility while this is still in flux. If anyone strongly disagrees in the reviews I'll revisit.Also noting that while we can build v24/v22 in RISC-V with gcc I'm only making changes for the v25+ clang sections for now.