Skip to content

refactor(convert_output): FIMS has year - #514

Draft
kellijohnson-NOAA wants to merge 1 commit into
mainfrom
refactor-del-year_i
Draft

kellijohnson-NOAA wants to merge 1 commit into
mainfrom
refactor-del-year_i

Conversation

@kellijohnson-NOAA

@kellijohnson-NOAA kellijohnson-NOAA commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

What is the feature?

  • Change year_i to year for fims converter

How have you implemented the solution?

  • Removed start_year argument everywhere because it only pertained to FIMS models
  • Changed year_i to year

Does the PR impact any other area of the project, maybe another repo?

PR contribution checklist

Thank you for contributing to stockplotr! Please check the boxes below to confirm this pull request (PR) is ready for review. Edit this PR description to add the release indicator and any explanations.

  • I have read and adhered to the contributor guide.
  • I have kept this PR focused on one plot where applicable. For multiple features, I have used separate PRs (stacked PRs are welcome if needed).
  • I have aimed to keep this PR to no more than 750 lines, excluding tests and example data (for example, up to 750 lines for a new function).
  • If I have provided an example dataset, I have explained why the existing sample datasets are not sufficient.
  • I have tested that my changes are compatible with all example outputs in the "data" folder (example_data.rda; pollock.rda; ss3_simple.rda; vermilion_snapper.rda).
  • If I didn't follow the development workflow, I have explained why in this PR.
  • If applicable, I've added the plot to save_all_plots() and updated the associated tests in test-save_all_plots.R.
  • After opening this PR, I have checked that my own tests and spellcheck pass (spelling::spell_check_package()). If other checks fail, I have flagged them for the package maintainers to help diagnose and remedy.
  • I have requested review from one package maintainer (Sam or Sophie).

No longer need to convert year_i to year or need the start_year argument

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant