Make the header full width and move copy+PR actions to header#84
Closed
danfishgold wants to merge 1 commit into
Closed
Make the header full width and move copy+PR actions to header#84danfishgold wants to merge 1 commit into
danfishgold wants to merge 1 commit into
Conversation
Member
|
I like it, and I don't like the current buttons on the right bottom, but I'm not sure how I feel about a persistent top bar in Codiff. I think it would be much more fitting to use a persistent bottom bar, similar to what we already use in walkthroughs. What do you think? |
Contributor
Author
|
I think top bar is more conventional but bottom bar works too! either option would be better than the floating buttons in my opinion. |
Member
|
Ok, closing for now. Might get to it, if not, please send a PR in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current issues
The action buttons are currently hovering at the bottom of the window:
This has some issues with the walkthrough's footer (as you can see in the screenshot) but also, and continuing my notes from #83, the GH buttons are unclear: at first I wasn't sure what they do so I clicked the checkmark and accidentally approved a PR 😬
An unrelated issue for me is that the window title is almost always truncated and when I have multiple Codiff windows open it makes it hard to understand which is which:
Proposed header
Right now when the sidebar is collapsed the header takes up the full width anyway so I thought I'd make it more consistent, and now that it's always there (and wide enough) there's room to put the floating buttons:
Related suggestions