kvantum: install kvantum packages#8974
kvantum: install kvantum packages#8974claymorwan wants to merge 1 commit intonix-community:masterfrom
Conversation
|
Any app I can help test this PR with? |
as in app to theme ? well any qt6 and qt5 apps should do, personally i tried with prism launcher (qt6) and limo (qt5) |
| qt5 = { | ||
| enable = mkEnableOption "Kvantum Qt5 support"; | ||
| package = mkPackageOption pkgs.libsForQt5 "qtstyleplugin-kvantum" { | ||
| nullable = true; | ||
| extraDescription = '' | ||
| The package to use for Kvantum Qt5 support. | ||
| ''; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
how does this differ from the style option already available in the qt options?
There was a problem hiding this comment.
oh i was not aware of this option, ig it works for people who wish to use kvantum paired with qtct like I do, I thought it'd be nice to have them seperate
There was a problem hiding this comment.
I'm struggling with the concept here. Sorry, brain might just be fried, but I'm trying to think of deduplication and least confusing UX. If we have options in the QT module for this and then we nest kvantum within the qt namespace, what is the goal of another nested qt option within.
There was a problem hiding this comment.
Well I want to give the user the choice wether they want kvantum to theme qt5 apps (which needs the qt5 version of kvantum to be installed) or not. Tho if you prefer I can just remove qt.kvantum.qt5 and make it so qt.kvantum.enable installs both the qt6 and qt5 version of kvantum.
claymorwan
force-pushed
the
kvantum-packages
branch
from
66db435 to
51091e7
Compare
claymorwan
force-pushed
the
kvantum-packages
branch
2 times, most recently
from
1935b23 to
8336664
Compare
|
Ok I had a lil of trouble with checking if both |
claymorwan
force-pushed
the
kvantum-packages
branch
from
8336664 to
bf58d29
Compare
claymorwan
force-pushed
the
kvantum-packages
branch
from
bf58d29 to
1d613d0
Compare
4 participants
Description
Kvantum theming won't actually work if kvantum isn't installed, and the kvantum hm module doesn't install it.
Addtionally, Qt5 apps won't be themed if the Qt5 version of kvantum isn't installed either
The changes from this PR are:
qt.kvantum.package(default:pkgs.kdePackages.qtstyleplugin-kvantum)qt.kvantum.package.qt.kvantum.qt5.enable(default:false), enabling it install the package set inqt.kvantum.qt5.packageqt.kvantum.qt5.package(default:pkgs.libsForQt5.qtstyleplugin-kvantum)Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.