Skip to content

fix(vercel): skip ISR routes in observability routes - #4716

Merged
pi0 merged 1 commit into
mainfrom
fix/vercel-o11y-isr-routes
Oct 3, 2026
Merged

pi0 merged 1 commit into
mainfrom
fix/vercel-o11y-isr-routes

Conversation

@pi0x

@pi0x pi0x commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Follow-up to #4698 (#4447, #4592)

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)

📚 Description

Routes with an ISR rule already skip their observability function, but they were still listed in config.json, pointing to a function that is never created. Since #4698 those entries can't be reached (the ISR route before them always matches first), so this only cleans up the output.

The ISR check moves from the function loop into getObservabilityRoutes, so the functions and the config.json routes come from the same filtered list. Tests are adapted from #4592 by @ShreeBohara.

🤖 Generated with AI assistant

Filtering in `getObservabilityRoutes` also drops their `config.json` route entries, which pointed to functions that are never created.
@pi0x
pi0x requested a review from pi0 as a code owner October 3, 2026 16:59
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nitro.build Ready Ready Preview Oct 3, 2026 4:59pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1f77ed9-09a9-44d2-a107-2eeeed754195
📥 Commits

Reviewing files that changed from the base of the PR and between a136558 and 212b792.

📒 Files selected for processing (2)
  • src/presets/vercel/utils.ts
  • test/unit/vercel-observability-routes.test.ts
 ______________________________________________________
< Plot twist: Your tests were the real bugs all along. >
 ------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4716

commit: 212b792

@pi0
pi0 merged commit e5d6076 into main Oct 3, 2026
14 of 15 checks passed
@pi0
pi0 deleted the fix/vercel-o11y-isr-routes branch October 3, 2026 17:04

This branch was successfully deployed

1 active deployment
Preview — 212b7928 Deployed Oct 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants