fix(cloudflare): warn only about conflicting asset overrides - #4690
Conversation
|
@harlan-zw is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
User wrangler config paths are relative to that file, while context config paths end up in the generated config. Compare resolved paths instead of normalized strings, and attribute the warning to the source that conflicts.
|
I pushed 02345c6 on top: the directory check was comparing strings from different bases (a root Triaged with AI assistance. |
❓ Type of change
📚 Description
A valid
assets.html_handlingsetting triggers an override warning even though Nitro retains it in generated Wrangler configuration. Warn only when Nitro replaces the effective asset binding or directory. Respect context configuration precedence for each field.📝 Checklist