Skip to content

docs: update file length issue breakdown #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prateep07 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

docs: update file length issue breakdown #124

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d9e574
docs: update file length issue breakdown
Nov 5, 2026
0841e86
docs: separate OAuth and transport issue scopes
Nov 5, 2026
cecb0f1
docs: include flight example in CLI split scope
Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions docs/investigations/file-length-limit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,17 +148,20 @@ Implementation issue scopes:
new Python files; block baseline growth; reduce baselines as files shrink;
add the CI step; document the scope and update/create `CONTRIBUTING.md`.
Out of scope: splitting files or changing line counting to logical SLOC.
2. [**Split core application and CLI modules behind compatibility facades**](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/112) (**filed**). Use the boundaries above, preserve
`nitrostack.core.app` imports and the `nitrostack.cli.main:main` entry point,
and add/update focused tests for the public imports and generated CLI output.
Out of scope: unrelated behavior changes or broad code cleanup.
3. [**Split remaining over-limit Python files by responsibility**](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/113) (**filed**). Batch related
implementation files with their tests (HTTP/widgets/auth/packing), then split
the large test modules and flight-booking example by topic. Start `app.py`
and `http.py` after PR #37 merges, and `cli/main.py` after PR #16 merges; then
remeasure from the latest `develop`. Recheck all open PRs before assigning
work. Out of scope: unrelated changes and line-count-only reshuffling.

GitHub issues #111, #112, and #113 are open. PRs #37 and #16 remain open and
touch planned split targets; wait for them to merge, then remeasure `develop`
before starting the overlapping splits.
2. [**Split core application and CLI modules behind compatibility facades**](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/112) (**open, umbrella**). Its two implementation scopes are tracked as standalone issues:
[CLI `main.py` and flight-booking example (#119)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/119)
and [core `app.py` (#120)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/120).
Preserve the CLI entry point and `nitrostack.core.app` compatibility imports.
3. [**Split remaining over-limit Python files by responsibility**](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/113) (**open, umbrella**). The implementation scopes are tracked as standalone issues:
[widget route templates and views (#121)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/121),
[OAuth (#122)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/122),
[CLI packaging (#123)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/123),
and [HTTP transport (#125)](https://github.com/nitrocloudofficial/nitrostack-python-sdk/issues/125).
The standalone issues exclude tests. The flight-booking example is included
in #119; other example-related files remain out of scope.

Before starting an overlapping split, refresh open-PR changed-file lists and
remeasure from the latest `develop`. PRs #37 and #16 were previously identified
as overlapping the core app, HTTP transport, and CLI main targets; confirm their
current status before work begins. The large test modules listed above are not
included in issues #119–#125 and need separate scoping if they are to be split.
Loading