Repository navigation
refactor(mcp): finish #27 cleanup (test-only registries, wire leftovers) - #108
Merged
Merged
Conversation
Remove runtime/acceptance.py, runtime/conformance.py and protocol/layers.py. Nothing in production imported them; they only backed layout/count tests, which go with them. Behavioural tests in the same files stay. In core/app.py, drop the second copy of the 2026 task-augmentation guard, the -32021 branch between the two copies (has_task_support is only False on auto/modern, which the first guard already rejects with -32602), the unused _stamp_discover_meta() helper and the now-unused import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
manish-wekan
marked this pull request as ready for review
November 4, 2026 09:43
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes #27 and the leftovers from #24/#78. Builds on @jpsiddharth2008's code commit from #37 (
2bb5dfa, cherry-picked with his authorship; conflicts resolved the same way as hisc5b0427), without #37's two review-log docs.Tests: registry/layout/count tests removed from
test_mcp20_acceptance.py,test_mcp20_blueprint.py,test_mcp20_foundation.py; their behavioural tests stay.test_mcp24_wire_alignment.py(from #37) added.InFlightRegistryis still wired inapp.py, sotest_mcp20_concurrency.pystays (#27 item 6 is conditional on its deletion).Evidence
develop@0d51ee4):server/discoverwithout headers →-32022(HTTP 200);rg "ACCEPTANCE_CRITERIA|PROTOCOL_DELIVERABLES|assert_blueprint_layout" nitrostack tests→ hits; 1159 passed.-32020(400 onmodern); ping →-32601; task-augmented call on modern/auto →-32602, legacy → task created (unchanged); [mcp-2026] Replace sidecar tests with a TestClient matrix; drop ping exports #27 proberg→ empty;tests/test_mcp20_*.py4,438 lines; 1227 passed locally (Python 3.12).Merge Danger
Door: two-way
Pure deletions plus #37's wire fix; revert restores everything.
Blast Radius: imports
nitrostack.protocolno longer exportsRuntimeLayer,MODERN_METHOD_CONTRACTS,MethodContract,contract_for,mcp_method_is_required,mcp_name_field,mcp_name_is_required,INITIALIZE_METHOD,build_sessionless_initialize_result. None are used in production code or templates; external code importing them would break (0.3.x, pre-1.0).Closes #27
🤖 Generated with Claude Code