Repository navigation
Conversation
This allows tools to import only the `-m` option without `-D`. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Extract `combine_main_module` out of `make_main_module` to be used from nitls. This service builds the main module of a program, importing all its modules and applying the conditional importations. The service `make_main_module` remains to be shared by the different engines and run the phases on the newly created fictive main module. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Without knowledge of -m, nitls would parse it as a module name and fail silently when used to build the dependencies of a Makefile. The module name after the `-m` was used as a target module but wouldn't trigger conditional imports as it was treated as a different entrypoint. Allow nitls to support conditional imports by making it aware of `-m` and have it build the fictive main module when needed. Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Test Results 67 files 337 suites 12m 19s ⏱️ Results for commit 3b7bedd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without knowledge of -m, nitls would parse it as a module name and fail silently when building the dependencies of a Makefile. The module name after the
-mwas used as a target module but wouldn't trigger conditional imports as it was treated as a different entry point.Allow nitls to support conditional imports by making it aware of
-mand have it build the fictive main module when needed. This replicates the behavior of nitc, applying the mixin modules to each main entrypoint.