Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-commit-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Rebuild the extension bundle
run: bun run build
Expand Down
25 changes: 19 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,21 @@ jobs:
with:
bun-version: 1.3.14

# `--frozen-lockfile` on every install in this repository's workflows.
# Without it, `bun install` treats a lockfile that disagrees with a
# `package.json` as something to silently rewrite: it exits 0, updates
# `bun.lock` in the runner, and the job proceeds against a dependency
# graph nobody committed. That is not hypothetical -- `bun.lock`
# recorded the extension at 0.4.1 and a peer range of `<18` while
# `package.json` said 0.6.0 and `<19`, through an unknown number of
# green pipelines, because no job ever asked. Measured both ways on
# the same drift: plain `bun install` exits 0 and rewrites the file;
# `--frozen-lockfile` exits 1 and names the fix.
#
# When this fails, the lockfile is genuinely out of date: run
# `bun install` locally and commit the resulting `bun.lock`.
- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

# Biome formats the JS/TS half. `cargo fmt` above covers Rust only,
# so without this a TypeScript formatting regression reaches main
Expand Down Expand Up @@ -170,7 +183,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Run Rust tests
run: cargo test --workspace
Expand All @@ -188,7 +201,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

# `strict: true` was declared from day one but never enforced: no local
# script and no CI job ran `tsc`, so real compile errors shipped in
Expand All @@ -206,7 +219,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Check generated code is up to date
run: bun run generate --check
Expand All @@ -221,7 +234,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Fail if the bundle is not a tracked file
run: git ls-files --error-unmatch packages/extension/dist/index.js
Expand Down Expand Up @@ -254,7 +267,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Run dependency audit
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/refresh-bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# refresh the bundle. Until this workflow exists on the default branch
# (dispatch requires that), the equivalent is:
# docker run --platform linux/amd64 -v $REPO:/src -w /src oven/bun:1.3.14 \
# sh -c "bun install && bun run build"
# sh -c "bun install --frozen-lockfile && bun run build"
# on a source copy. See the bundle-check job in ci.yml.
name: Refresh Committed Bundle (manual)

Expand All @@ -25,7 +25,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile

- name: Rebuild the extension bundle
run: bun run build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
bun-version: 1.3.14

- name: Install JS workspace dependencies
run: bun install
run: bun install --frozen-lockfile
- name: Run conformance unit tests
run: bun test tests/conformance

Expand Down
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,14 @@ what makes them evidence, and `assets/`, where the logo's parts carry labels of
`release/live-conformance/*.json` is exempt for the same reason as `fixtures/` — those reports are
harness output copied verbatim — while that directory's README, being authored prose, is not.

### The lockfile is checked, not repaired, by CI

Every workflow installs with `bun install --frozen-lockfile`. If `bun.lock` disagrees with any
`package.json`, the job fails and says so, rather than quietly resolving a different dependency
graph and continuing — which is what a plain `bun install` does, exiting 0 and rewriting the
lockfile in the runner where nobody sees it. Run `bun install` locally and commit the updated
`bun.lock` in the same change that touched the dependency.

### Commit messages carry technical content only

No tool attribution, no agent names, no session links. A trailer of that kind says nothing about the
Expand Down
Loading