Revise wording for proxy_view and related facilities#19
Open
mingxwa wants to merge 2 commits intongcpp:mainfrom
Open
Revise wording for proxy_view and related facilities#19mingxwa wants to merge 2 commits intongcpp:mainfrom
proxy_view and related facilities#19mingxwa wants to merge 2 commits intongcpp:mainfrom
Conversation
mingxwa
force-pushed
the
user/mingxwa/revise-proxy-view-spec
branch
from
92d78bd to
a14410f
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the specification wording around proxy_view-related facilities to match the actual definitions in proxy.h and to clarify address-taking behavior without implying use of operator&.
Changes:
- Corrects the
proxiable_targetspec to useobserver_facade<F>(aligning withproxy.h). - Updates
make_proxy_viewwording to usestd::addressof(value)instead of&value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/spec/proxiable_target.md | Fixes the formal definition of proxiable_target to match the proxy_view/observer_facade model. |
| docs/spec/make_proxy_view.md | Adjusts wording to avoid operator& by specifying std::addressof(value). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
proxiable_target's spec was wrong (see the correct definition inproxy.h).operator &make_proxy_view()'s wording.No functional changes.