Skip to content

Fix internal links in external-use.md#4265

Merged
mashehu merged 1 commit into
nf-core:mainfrom
pmoris:fix-link
Jun 22, 2026
Merged

Fix internal links in external-use.md#4265
mashehu merged 1 commit into
nf-core:mainfrom
pmoris:fix-link

Conversation

@pmoris

@pmoris pmoris commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The (relative) links on the page about external use of nf-core don't seem to work as intended. This should fix it I hope.

@netlify /docs/developing/external-use

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for nf-core-docs ready!

Name Link
🔨 Latest commit bb6d5f8
🔍 Latest deploy log https://app.netlify.com/projects/nf-core-docs/deploys/6a3512e48214550008c5b64e
😎 Deploy Preview https://deploy-preview-4265--nf-core-docs.netlify.app/docs/developing/external-use
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit bb6d5f8
🔍 Latest deploy log https://app.netlify.com/projects/nf-core-main-site/deploys/6a3512e42d5f710008b93c53
😎 Deploy Preview https://deploy-preview-4265--nf-core-main-site.netlify.app/docs/developing/external-use
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pmoris

pmoris commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Hm. Still doesn't work in the preview deployment it seems.

For example, the first one (../nf-core-tools/CLI/pipelines/lint#linting-config) points to https://deploy-preview-4265--nf-core-main-site.netlify.app/nf-core-tools/CLI/pipelines/lint#linting-config now, but it should be https://deploy-preview-4265--nf-core-main-site.netlify.app/docs/nf-core-tools/cli/pipelines/list.

Are the paths relative to the content page, instead of to the current document?

EDIT: Odd. Changed it back and forth a few times, and now it does seem to work the way I'd expect it to.

@mashehu

mashehu commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@mashehu mashehu merged commit 0a24b67 into nf-core:main Jun 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants