Add metadata for agent-discovery#4244
Merged
Merged
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mashehu
reviewed
Jun 8, 2026
mashehu
reviewed
Jun 8, 2026
mashehu
reviewed
Jun 8, 2026
Validates sites/main-site/public/.well-known/api-catalog against public/: drift (catalog links a static file that's missing) and coverage (a machine-readable file exists but isn't listed). Runs as a job in linting.yml and via `npm run check-api-catalog`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mashehu
reviewed
Jun 8, 2026
Addresses review feedback: revert the Access-Control-Allow-Origin splat from /* back to /_astro/* (its original purpose: cross-origin assetsPrefix modules), and add ACAO only to the homepage and the machine-readable discovery resources that browser JS actually reads cross-origin. The paths are disjoint, so ACAO is set by exactly one rule per request. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mashehu
reviewed
Jun 8, 2026
Extend check-api-catalog.js with a third check: every static discovery resource (the catalog plus the .json/.txt files it links to) must have an Access-Control-Allow-Origin rule in netlify.toml, and no stale discovery CORS rules linger — the same resource list, kept consistent across files. Move the check from a standalone linting.yml job to a local pre-commit hook, so it runs locally on commit and is picked up automatically by the existing prek CI job. Scoped to the relevant paths, so it only runs when they change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Per review: the catalog is the single discovery entry point, so drop the per-JSON and llms.txt Access-Control-Allow-Origin rules (those files are served same-origin from every sub-site via symlinks, and crawlers read them server-side where CORS is moot). CORS now covers /_astro/*, /, and /.well-known/api-catalog only. Rework the api-catalog check #3 to match: assert the catalog itself is cross-origin readable, rather than requiring CORS on every listed resource. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ewels
force-pushed
the
agent-discovery-link-headers
branch
from
b85bf6f to
155fe30
Compare
mashehu
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered via https://isitagentready.com/nf-co.re