cellpheno/nis: add test tile + models#2136
Open
Chrisa142857 wants to merge 1 commit into
Open
Conversation
mashehu
requested changes
Jul 9, 2026
Contributor
There was a problem hiding this comment.
this file is too big, we usually aim for as small as possible, target <1MB. Any chance you can shrink this and the second file?
99a302a to
50996d5
Compare
50996d5 to
5015ac1
Compare
Member
Author
|
Thanks @mashehu! Addressed:
So this PR now adds a single ~700 KB file. NIS still segments 221 nuclei on the crop. |
mashehu
approved these changes
Jul 9, 2026
mashehu
left a comment
Contributor
There was a problem hiding this comment.
awesome and thanks for cleaning up the git history!
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test data for the
cellpheno/nismodule (nf-core/modules#12179).data/imaging/segmentation/cellpheno_nis/cellpheno_nis_tile.zip— a real P4 partial-brain crop: 30 z-slices, 384×384 (2D OME-TIFF), ~4 MB.data/imaging/segmentation/cellpheno_nis/cellpheno_nis_models.zip— the TorchScript NIS models (cuda:0 set), ~64 MB.Both are zipped so the module test extracts them via the
UNZIPsubworkflow (dir inputs), following thenumorph/3dunetpattern. Verified: NIS segments 351 nuclei on this crop.