Add ldak/thinpredictors module#12293
Merged
Merged
Conversation
Primary module: ldak/thinpredictors. Bundled test-dependency modules: (none). Ported and reorganised from the LDAK module family (nf-core naming, fixed container/version/contract issues).
chriswyatt1
approved these changes
Jul 9, 2026
chriswyatt1
left a comment
Contributor
There was a problem hiding this comment.
Great, checked through that, and it all looks correct.
Are we sure process_medium is the best generic setting to use?
Contributor
|
Actually |
chriswyatt1
previously requested changes
Jul 9, 2026
This is not an issue, they are being used in the script
Contributor
Author
I think process_medium is fine for this module but honestly I've been using it as a generic placeholder... I'll replace with more sensible settings for other modules - some do deserve process_high. |
SPPearce
reviewed
Jul 9, 2026
…s, add ontologies, minimise test assertions
SPPearce
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This PR adds the
ldak/thinpredictorsmodule. It runs LDAK (ldak6 --thin) to perform linkage-disequilibrium pruning on a PLINK binary fileset (bed/bim/fam) and emit a thinned predictor list, which downstream LDAK steps use to build weighted kinship matrices. It upstreamsmain.nf,meta.yml,environment.yml, and nf-test tests (including a stub), with topic-based version reporting. Tests reuse the existing publicplink_simulatedfixtures fromnf-core/test-datasets; no new test data required.plink_simulatedfixtures).topic: versions- See version_topicslabelnf-core modules test ldak/thinpredictors --profile dockernf-core modules test ldak/thinpredictors --profile singularitynf-core modules test ldak/thinpredictors --profile conda