Skip to content

implemented readgroup addition in fastq_align_chromap, since chromap has no option to do it#12283

Merged
JoseEspinosa merged 5 commits into
nf-core:masterfrom
Kevin-Brockers:fastq_align_chromap
Jul 8, 2026
Merged

implemented readgroup addition in fastq_align_chromap, since chromap has no option to do it#12283
JoseEspinosa merged 5 commits into
nf-core:masterfrom
Kevin-Brockers:fastq_align_chromap

Conversation

@Kevin-Brockers

Copy link
Copy Markdown
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question but otherwise LGTM!

Comment thread subworkflows/nf-core/fastq_align_chromap/main.nf Outdated
@JoseEspinosa

Copy link
Copy Markdown
Member

Ah, I see this is done in #523 I guess

@JoseEspinosa JoseEspinosa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚀

@JoseEspinosa JoseEspinosa enabled auto-merge July 8, 2026 14:58
@JoseEspinosa JoseEspinosa added this pull request to the merge queue Jul 8, 2026
Merged via the queue into nf-core:master with commit 928a982 Jul 8, 2026
32 checks passed
@Kevin-Brockers Kevin-Brockers deleted the fastq_align_chromap branch July 8, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants