Skip to content

Second step of proteomics support: Download files of PRIDE projects - #422

Merged
Tabea01 merged 9 commits into
nf-core:devfrom
Tabea01:feat/pride-download
Nov 19, 2026
Merged

Tabea01 merged 9 commits into
nf-core:devfrom
Tabea01:feat/pride-download

Conversation

@Tabea01

@Tabea01 Tabea01 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Installed the nf-core module pridepy/downloadfile

  • New parameter --proteomics_file_categories (default RAW; also PEAK, SEARCH, RESULT, SPECTRUM_LIBRARY, OTHER, FASTA)

  • SDRF files are always downloaded if the project has one

  • Warning if a selected category doesn't exist in a project, listing the available categories

  • --skip_fastq_download also applies to PRIDE ids; PRIDE files are always downloaded via FTP

  • Output: proteomics/files/<id>/

  • Tests, docs and README updated

  • Not in this PR: samplesheet/SDRF conversion, other repositories (MassIVE, jPOST, iProX).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nf-test test --verbose --debug --profile "+docker" tests/).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@Tabea01 Tabea01 closed this Nov 17, 2026
@github-actions

Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @Tabea01,

It looks like this pull-request is has been made against the Tabea01/fetchngs master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the Tabea01/fetchngs dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f90ca1b

+| ✅ 197 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-fetchngs_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-fetchngs_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-fetchngs_logo_dark.png
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 4.2.2
  • Run at 2026-11-19 10:58:39

@Tabea01 Tabea01 reopened this Nov 17, 2026
@Tabea01
Tabea01 changed the base branch from master to dev November 17, 2026 15:10
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 7/7

See the full run for details.

@Tabea01
Tabea01 marked this pull request as ready for review November 19, 2026 11:22
input[6] = 'auto'
input[7] = ''
input[8] = false
input[8] = true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not skipping the fastq download?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this on purpose, because otherwise it downloads the RAW file, this test is metadata only. The test in pride_download.nf.test downloads with the smaller OTHER file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change this params name at some point then?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or are the RAW files fastqs in that case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i think it would be good to rename skip_fastq_download to skip_download at some point

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAW are mass spec files

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why i was confused, let's create an issue for this then, so we don't forget

@maxulysse maxulysse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tabea01
Tabea01 merged commit e43b3e2 into nf-core:dev Nov 19, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants