nmc/5917-android-add-folder-popup-does-not-close-after-tapping-X-button-in-Photo-Settings#486
Open
suet-kei-chan wants to merge 1 commit into
Conversation
The modal-container__content element was receiving overflow-y: auto via the NMC theme override, turning it into a scroll container. On Android Chrome, this scroll container intercepts touch events in its rendered bounds — which overlaps with the absolutely-positioned close button (top: 0.5rem, right: 0.5rem). As a result, tapping the X button had no effect on Android tablets (tested on Samsung Galaxy Tab A8 / Android 14 and Lenovo Tab M10 / Android 12). NcDialog intentionally sets modal-container__content to overflow: hidden and handles scrolling one level deeper at dialog__content. The NMC override was defeating this by making the outer container a touch scroll target. Fix: separate the combined &__content, .dialog__content selector so that overflow-y: auto only applies to .dialog__content (where scrolling belongs), leaving modal-container__content without an overflow override. NcDialog's own scoped CSS (overflow: hidden) now applies correctly, eliminating the touch event interception on Android.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modal-container__content element was receiving overflow-y: auto via the NMC theme override, turning it into a scroll container. On Android Chrome, this scroll container intercepts touch events in its rendered bounds — which overlaps with the absolutely-positioned close button (top: 0.5rem, right: 0.5rem). As a result, tapping the X button had no effect on Android tablets (tested on Samsung Galaxy Tab A8 / Android 14 and Lenovo Tab M10 / Android 12).
NcDialog intentionally sets modal-container__content to overflow: hidden and handles scrolling one level deeper at dialog__content. The NMC override was defeating this by making the outer container a touch scroll target.
Fix: separate the combined &__content, .dialog__content selector so that overflow-y: auto only applies to .dialog__content (where scrolling belongs), leaving modal-container__content without an overflow override. NcDialog's own scoped CSS (overflow: hidden) now applies correctly, eliminating the touch event interception on Android.