nmc/5798-files-sharing-expiration-date-field-size-is-too-big#485
Open
suet-kei-chan wants to merge 1 commit into
Open
nmc/5798-files-sharing-expiration-date-field-size-is-too-big#485suet-kei-chan wants to merge 1 commit into
suet-kei-chan wants to merge 1 commit into
Conversation
The expiration date input (#share-date-picker) in the sharing modal was rendering at 628x59 in Safari while other inputs (label, password) rendered at the correct 582x57 size. Root cause: Safari enforces a native intrinsic minimum width and height on type="date" inputs when -webkit-appearance is not explicitly reset. This caused the date picker to overflow its container width by ~46px and exceed the intended height by ~3px regardless of the CSS width/height rules in ncfields.scss. Fix: - Add -webkit-appearance: none and appearance: none to remove Safari's native date picker chrome, allowing the existing width: calc(100% - 10px) from ncfields.scss to apply correctly - Add box-sizing: border-box to ensure padding is absorbed within the declared dimensions - Add height: 56px !important scoped directly on #share-date-picker to explicitly override Safari's native input height Affects: .sharingTabDetailsView and .sharingPopupDetailsView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expiration date input (#share-date-picker) in the sharing modal was rendering at 628x59 in Safari while other inputs (label, password) rendered at the correct 582x57 size.
Root cause: Safari enforces a native intrinsic minimum width and height on type="date" inputs when -webkit-appearance is not explicitly reset. This caused the date picker to overflow its container width by ~46px and exceed the intended height by ~3px regardless of the CSS width/height rules in ncfields.scss.
Fix:
Affects: .sharingTabDetailsView and .sharingPopupDetailsView