Skip to content

Fix deprecated InvalidArgumentException usage in Notifier.php - #1155

Closed
sjg2203 wants to merge 1 commit into
nextcloud:mainfrom
sjg2203:fix-notifier-exception
Closed

sjg2203 wants to merge 1 commit into
nextcloud:mainfrom
sjg2203:fix-notifier-exception

Conversation

@sjg2203

@sjg2203 sjg2203 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Refactor createNotificationException to always return UnknownNotificationException, resolving repeated log warnings about deprecated InvalidArgumentException.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Refactor createNotificationException to always return UnknownNotificationException.

Signed-off-by: S.J. Guillot <58807831+sjg2203@users.noreply.github.com>
@come-nc

come-nc commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

This was fixed by #1134 already.
Your version is only possible when we drop older versions.

@come-nc come-nc closed this Aug 7, 2026
@sjg2203

sjg2203 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

This was fixed by #1134 already. Your version is only possible when we drop older versions.

Right (completely forgot about it!), #1134 hasn't gone into production yet (not part of v10.4.0), right? If it did, it seems that it didn't fix the issue.
For older versions, seems Nextcloud stance is that it only support Nextcloud 30+ with only 32+ still receiving updates. I would think that when Nextcloud 35 will be released, support for 32 will be dropped. The fix supposedly fixes it for both 29 and 30+, but in the long run, would it be best to drop support for version <30/32?

@sjg2203
sjg2203 deleted the fix-notifier-exception branch August 19, 2026 16:41
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants