Repository navigation
fix(share): check the share password hash for authenticated public shares - #9634
Open
juliusknorr wants to merge 1 commit into
Open
juliusknorr wants to merge 1 commit into
juliusknorr wants to merge 1 commit into
Conversation
juliusknorr
marked this pull request as ready for review
November 18, 2026 21:41
juliusknorr
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
November 18, 2026 21:41
…ares Use PublicAuth::isShareInSession() from the server when available, so access follows the current share password. Older server releases without the helper keep using the list of authenticated share ids. Signed-off-by: Julius Knorr <jus@bitgrid.net> Assisted-by: ClaudeCode:claude-opus-5-5
juliusknorr
force-pushed
the
fix/public-share-session-hash
branch
from
November 18, 2026 21:44
1d22b63 to
6003dad
Compare
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use the server's
PublicAuth::isShareInSession()to check public share sessions, so access follows the current share password. Older server releases without the helper keep the existing share id check.FileService::isShareAuthenticated(), used byFileService,WorkspaceControllerandAttachmentController::getAuth()getAuth(), so the duplicate check inAttachmentServiceis goneis_callable, so servers without the public static helper fall back without errors🏁 Checklist
composer run cs:check)FileService,WorkspaceControllerandAttachmentController, for both server variants🤖 AI (if applicable)