Skip to content

build: exclude development files from app releases - #9595

Merged
skjnldsv merged 1 commit into
mainfrom
fix/nextcloudignore
Nov 16, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
fix/nextcloudignore

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

📝 Summary

The release build still has to delete these development files itself because this app's .nextcloudignore doesn't list them. nextcloud-releases/server#137 now reports that per app. This adds them, anchored to the app root and sorted like recommendations' file. composer.json, package.json and their lock files stay in the release on purpose, for traceability.

It also drops entries for files that no longer exist on any branch.

I checked it with git ls-files -ci --exclude-from=.nextcloudignore on main, stable35, stable34 and stable33: no development file is left at the root, and nothing else changes in what ships.

🏁 Checklist

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv self-assigned this Nov 13, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 13, 2026
@skjnldsv
skjnldsv enabled auto-merge November 13, 2026 04:12

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However: REUSE.toml already annotates .nextcloudignore as CC0-1.0 / copyright "none" with precedence = "aggregate". The new header adds AGPL-3.0-or-later on top, so the file now carries two different licenses. The reuse check still passes, but the license data is inconsistent.

List every development file the release tooling still has to remove, anchored to the app root and sorted, so the app's own .nextcloudignore covers them. composer.json, package.json and their lock files stay in the release for traceability.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@mejo-
mejo- force-pushed the fix/nextcloudignore branch from 3cfd6d3 to 5ebb40d Compare November 16, 2026 15:55

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a rebase with the license header removed again from .nextcloudignore.

@skjnldsv
skjnldsv merged commit 04c882b into main Nov 16, 2026
65 checks passed
@skjnldsv
skjnldsv deleted the fix/nextcloudignore branch November 16, 2026 16:06
@mejo-

mejo- commented Nov 16, 2026

Copy link
Copy Markdown
Member

/backport to stable35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants