Repository navigation
fix(workspace): replace XML-invalid characters in rich workspace content - #9590
Merged
Merged
Conversation
blizzz
approved these changes
Nov 10, 2026
Member
Author
|
/backport to stable35 |
The rich-workspace DAV properties embed the folder's Readme.md content in the multistatus response as is. Control characters, U+FFFE/U+FFFF or invalid UTF-8 (e.g. a Readme.md left behind encrypted after disabling server-side encryption) make the whole response malformed, so strict clients like the iOS app fail to show the folder listing. NUL bytes also silently truncate the property value. Decode the content to UTF-8 the same way the editor does and replace characters that cannot be represented in XML 1.0 with U+FFFD. Fixes: #9511 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/workspace_xml_invalid_chars
branch
from
November 10, 2026 17:51
ae4419b to
6d60747
Compare
mejo-
enabled auto-merge
November 10, 2026 17:51
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/9590/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d60747a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9590/stable35Error: Failed to check for changes with origin/stable35: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
5 tasks done
Member
Author
|
Manual backport to stable35: #9592 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rich-workspace DAV properties embed the folder's Readme.md content in the multistatus response as is. Control characters, U+FFFE/U+FFFF or invalid UTF-8 (e.g. a Readme.md left behind encrypted after disabling server-side encryption) make the whole response malformed, so strict clients like the iOS app fail to show the folder listing. NUL bytes also silently truncate the property value.
Decode the content to UTF-8 the same way the editor does and replace characters that cannot be represented in XML 1.0 with U+FFFD.
Fixes: #9511
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)