Repository navigation
refactor(footnotes): render ordinals via decorations, not node attributes - #9580
Merged
Merged
Conversation
max-nextcloud
approved these changes
Nov 18, 2026
…utes Footnote numbers were stored as `ordinal` attributes on footnote and footnoteReference nodes and rewritten in appendTransaction on every document change. Being derived view state, they still ended up in the Yjs document and were synced between all clients. Compute the numbers in plugin state instead and hand them to the view as node decorations that set a `--footnote-ordinal` CSS variable, rendered via a CSS counter. Plain CSS counters are not enough on their own: repeated references to the same footnote must share a number, and the footnotes section is not necessarily in reference order. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/footnote_ordinals_decorations
branch
from
November 18, 2026 10:08
dd39b97 to
936f950
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footnote numbers were stored as
ordinalattributes on footnote and footnoteReference nodes and rewritten in appendTransaction on every document change. Being derived view state, they still ended up in the Yjs document and were synced between all clients.Compute the numbers in plugin state instead and hand them to the view as node decorations that set a
--footnote-ordinalCSS variable, rendered via a CSS counter. Plain CSS counters are not enough on their own: repeated references to the same footnote must share a number, and the footnotes section is not necessarily in reference order.Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)