Skip to content

fix(ci): build the assistant from git on server master - #9578

Merged
hweihwang merged 1 commit into
mainfrom
fix/ci-cypress-assistant-from-git
Nov 10, 2026
Merged

hweihwang merged 1 commit into
mainfrom
fix/ci-cypress-assistant-from-git

Conversation

@hweihwang

Copy link
Copy Markdown
Contributor

📝 Summary

The Cypress workflow checks out and builds the assistant only when matrix.server-versions == 'main', but the server branch in the matrix is master. Those two steps never run, so every runner fetches the assistant from the App Store with occ app:enable assistant --force. That fetch fails on some runners with "Could not download app assistant, it was not found on the appstore", although the App Store lists assistant 4.1.0 for Nextcloud 35 to 36, and the runner fails before any spec starts. In the last 100 Cypress runs this hit 14 branches, main PRs and backports alike.

This compares against master, so main builds the assistant from its main branch as b35d8a8 and bb8bcaf intended. The assistant's main supports Nextcloud 35 to 36, and server master is 36. Stable branches keep the App Store version.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

The Cypress workflow checks out and builds the assistant only when
`matrix.server-versions == 'main'`, but the server branch in the matrix
is `master`. Those steps never ran, so `occ app:enable assistant --force`
fetched the app from the App Store instead, which fails on some runners
with "Could not download app assistant, it was not found on the appstore".

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 9, 2026

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense to me.

@hweihwang
hweihwang marked this pull request as ready for review November 10, 2026 08:28
@hweihwang
hweihwang merged commit 6f441c0 into main Nov 10, 2026
70 of 72 checks passed
@hweihwang
hweihwang deleted the fix/ci-cypress-assistant-from-git branch November 10, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants