Repository navigation
fix(ci): build the assistant from git on server master - #9578
Merged
Merged
Conversation
The Cypress workflow checks out and builds the assistant only when `matrix.server-versions == 'main'`, but the server branch in the matrix is `master`. Those steps never ran, so `occ app:enable assistant --force` fetched the app from the App Store instead, which fails on some runners with "Could not download app assistant, it was not found on the appstore". Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
marked this pull request as ready for review
November 10, 2026 08:28
hweihwang
requested review from
max-nextcloud and
silverkszlo
as code owners
November 10, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
The Cypress workflow checks out and builds the assistant only when
matrix.server-versions == 'main', but the server branch in the matrix ismaster. Those two steps never run, so every runner fetches the assistant from the App Store withocc app:enable assistant --force. That fetch fails on some runners with "Could not download app assistant, it was not found on the appstore", although the App Store lists assistant 4.1.0 for Nextcloud 35 to 36, and the runner fails before any spec starts. In the last 100 Cypress runs this hit 14 branches, main PRs and backports alike.This compares against
master, so main builds the assistant from itsmainbranch as b35d8a8 and bb8bcaf intended. The assistant'smainsupports Nextcloud 35 to 36, and server master is 36. Stable branches keep the App Store version.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)