Skip to content

chore(dev-deps): pin rector to 2.8.1 and phpstan to 2.3.3 - #9548

Merged
mejo- merged 1 commit into
mainfrom
fix/pin_rector
Nov 4, 2026
Merged

mejo- merged 1 commit into
mainfrom
fix/pin_rector

Conversation

@mejo-

@mejo- mejo- commented Nov 4, 2026

Copy link
Copy Markdown
Member

nextcloud/rector 0.5.2 uses Rector\PhpDocParser\PhpDocParser\PhpDocNodeTraverser, which rector/rector removed in 2.8.2, so composer rector fails with "Class not found" errors.

rector/rector 2.8.1 and older break with phpstan/phpstan 2.3.4 and newer (FullyQualifiedNameNode TypeError), so phpstan must be pinned along with rector.

Remove the pins once nextcloud/rector supports rector 2.8.2+.

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

nextcloud/rector 0.5.2 uses Rector\PhpDocParser\PhpDocParser\PhpDocNodeTraverser,
which rector/rector removed in 2.8.2, so `composer rector` fails with
"Class not found" errors.

rector/rector 2.8.1 and older break with phpstan/phpstan 2.3.4 and newer
(FullyQualifiedNameNode TypeError), so phpstan must be pinned along with rector.

Remove the pins once nextcloud/rector supports rector 2.8.2+.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo- mejo- self-assigned this Nov 4, 2026
@mejo- mejo- added tests If you write them we ♥ you 3. to review labels Nov 4, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 4, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Productivity team Nov 4, 2026
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 4, 2026
@mejo-

mejo- commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@mejo-
mejo- merged commit bf8f1ee into main Nov 4, 2026
66 of 70 checks passed
@mejo-
mejo- deleted the fix/pin_rector branch November 4, 2026 20:55
@github-project-automation github-project-automation Bot moved this from 🏗️ In progress to ☑️ Done in 📝 Productivity team Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits tests If you write them we ♥ you

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

2 participants