Repository navigation
fix(viewer): keep the editor mounted after saving - #9545
Merged
Merged
Conversation
The viewer mounts a new element when the file it shows is announced with another etag, unless the element wrote the file and says so with update:file first. Text did not, and with files_lock every save announced the file with the etag taken under Text's lock. The viewer mounted the editor again, and each closing editor unlocked the file, changing its etag and announcing it once more, so the editor kept reloading. Tell the viewer of each save from the viewer's element, before announcing it to Files. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
fix/viewer_reload_on_save
branch
from
November 4, 2026 21:16
3c6a688 to
308a775
Compare
skjnldsv
approved these changes
Nov 4, 2026
mejo-
enabled auto-merge
November 4, 2026 21:32
mejo-
disabled auto-merge
November 4, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewer mounts a new element when the file it shows is announced with another etag, unless the element wrote the file and says so with update:file first. Text did not, and with files_lock every save announced the file with the etag taken under Text's lock. The viewer mounted the editor again, and each closing editor unlocked the file, changing its etag and announcing it once more, so the editor kept reloading.
Tell the viewer of each save from the viewer's element, before announcing it to Files.
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)