Skip to content

fix(viewer): keep the editor mounted after saving - #9545

Merged
mejo- merged 1 commit into
mainfrom
fix/viewer_reload_on_save
Nov 4, 2026
Merged

mejo- merged 1 commit into
mainfrom
fix/viewer_reload_on_save

Conversation

@mejo-

@mejo- mejo- commented Nov 4, 2026

Copy link
Copy Markdown
Member

The viewer mounts a new element when the file it shows is announced with another etag, unless the element wrote the file and says so with update:file first. Text did not, and with files_lock every save announced the file with the etag taken under Text's lock. The viewer mounted the editor again, and each closing editor unlocked the file, changing its etag and announcing it once more, so the editor kept reloading.

Tell the viewer of each save from the viewer's element, before announcing it to Files.

Assisted-by: ClaudeCode:claude-opus-5-5

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Nov 4, 2026
@mejo- mejo- added bug Something isn't working 3. to review regression labels Nov 4, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Nov 4, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Nov 4, 2026
@mejo-
mejo- requested a review from skjnldsv November 4, 2026 17:05
@nextcloud-command nextcloud-command added the AI assisted This PR contains AI-assisted commits label Nov 4, 2026
The viewer mounts a new element when the file it shows is announced
with another etag, unless the element wrote the file and says so with
update:file first. Text did not, and with files_lock every save
announced the file with the etag taken under Text's lock. The viewer
mounted the editor again, and each closing editor unlocked the file,
changing its etag and announcing it once more, so the editor kept
reloading.

Tell the viewer of each save from the viewer's element, before
announcing it to Files.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: ClaudeCode:claude-opus-5-5
@mejo-
mejo- force-pushed the fix/viewer_reload_on_save branch from 3c6a688 to 308a775 Compare November 4, 2026 21:16
@mejo-
mejo- enabled auto-merge November 4, 2026 21:32
@mejo-
mejo- disabled auto-merge November 4, 2026 21:36
@mejo-
mejo- merged commit c8ddda9 into main Nov 4, 2026
63 of 65 checks passed
@mejo-
mejo- deleted the fix/viewer_reload_on_save branch November 4, 2026 21:55
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review AI assisted This PR contains AI-assisted commits bug Something isn't working regression

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants