Repository navigation
Conversation
Opening a comparison from the viewer closes the editor, which saves unsaved changes on its way out. The comparison loaded the file at the same time, so it could show the file without those changes. It now waits for that save, up to 15 seconds, and shows its error when the save fails, is refused (a conflict or lost write access) or takes longer; loading again then compares the file as the server has it. Plain-text files, compared side by side in their source view, wait and fail the same way; an older version shown there does not wait, and every file shows as text, also one the browser could read as JSON. Files are served without caching rules, so the browser could also reuse an older copy of a file saved meanwhile. The comparison now asks with Cache-Control: no-cache, gives up after two minutes instead of waiting forever, and loads again when the viewer shows a newer state of the file, as after a restore. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
hweihwang
force-pushed
the
fix/comparison-closing-save
branch
from
November 9, 2026 11:36
9ab1765 to
b08c327
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Opening a comparison from the viewer closes the editor, which saves unsaved changes on its way out. The comparison loaded the file at the same time, so it could show the file without those changes.
Cache-Control: no-cache, and the requests give up after two minutes.First of five stacked PRs for #8904; it stands on its own.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)versions.spec.ts, which delays the save and fails without this fix🤖 AI (if applicable)