Repository navigation
chore(npm): allow scripts of known NPM dependencies - #8922
Merged
Merged
Conversation
Starting with NPM v12, scripts defined by dependencies need to be allowed explicitely to protect against supply-chain attacks. Signed-off-by: Jonas <jonas@freesources.org>
Comment on lines
+153
to
+161
| "allowScripts": { | ||
| "@parcel/watcher": true, | ||
| "core-js": true, | ||
| "cypress": true, | ||
| "esbuild": true, | ||
| "protobufjs": true, | ||
| "ssh2": true, | ||
| "cpu-features": true | ||
| } |
Contributor
There was a problem hiding this comment.
I think I only use cypress and esbuild. Do we actually need the others?
Member
Author
There was a problem hiding this comment.
The others are indirect dependencies and we have them since a long time. Until now (with NPM < v12), their scripts get executed all the time you run npm i or npm ci. If we don't add them, npm will mourn and show a warning each time. I think it's acceptable to add them.
max-nextcloud
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with NPM v12, scripts defined by dependencies need to be allowed explicitely to protect against supply-chain attacks.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)